From 2b0e31870d0ad68a4970eca56471ac150608a395 Mon Sep 17 00:00:00 2001
From: Alexander Dahl <alex@netz39.de>
Date: Sat, 8 Mar 2025 22:04:04 +0100
Subject: [PATCH] :rotating_light: roles: users: Fix linter warnings of type
'fqcn'
fqcn[action-core]: Use FQCN for builtin module actions (shell).
roles/users/handlers/main.yml:2 Use `ansible.builtin.shell` or `ansible.legacy.shell` instead.
fqcn[action-core]: Use FQCN for builtin module actions (package).
roles/users/tasks/main.yml:2 Use `ansible.builtin.package` or `ansible.legacy.package` instead.
fqcn[action-core]: Use FQCN for builtin module actions (lineinfile).
roles/users/tasks/main.yml:8 Use `ansible.builtin.lineinfile` or `ansible.legacy.lineinfile` instead.
fqcn[action-core]: Use FQCN for builtin module actions (user).
roles/users/tasks/main.yml:16 Use `ansible.builtin.user` or `ansible.legacy.user` instead.
fqcn[action]: Use FQCN for module actions, such `ansible.posix.authorized_key`.
roles/users/tasks/main.yml:24 Action `authorized_key` is not FQCN.
fqcn[action-core]: Use FQCN for builtin module actions (user).
roles/users/tasks/main.yml:34 Use `ansible.builtin.user` or `ansible.legacy.user` instead.
fqcn[action-core]: Use FQCN for builtin module actions (stat).
roles/users/tasks/main.yml:42 Use `ansible.builtin.stat` or `ansible.legacy.stat` instead.
fqcn[action-core]: Use FQCN for builtin module actions (lineinfile).
roles/users/tasks/main.yml:47 Use `ansible.builtin.lineinfile` or `ansible.legacy.lineinfile` instead.
---
roles/users/handlers/main.yml | 2 +-
roles/users/tasks/main.yml | 14 +++++++-------
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/roles/users/handlers/main.yml b/roles/users/handlers/main.yml
index 372d62a..04184af 100644
--- a/roles/users/handlers/main.yml
+++ b/roles/users/handlers/main.yml
@@ -1,3 +1,3 @@
---
- name: Update aliases
- shell: which newaliases && newaliases || true
+ ansible.builtin.shell: which newaliases && newaliases || true
diff --git a/roles/users/tasks/main.yml b/roles/users/tasks/main.yml
index 15fa0fc..3291b35 100644
--- a/roles/users/tasks/main.yml
+++ b/roles/users/tasks/main.yml
@@ -1,12 +1,12 @@
---
- name: Ensure sudo is installed
- package:
+ ansible.builtin.package:
name:
- sudo
state: present
- name: Configure group sudo for sudoers without password
- lineinfile:
+ ansible.builtin.lineinfile:
path: /etc/sudoers
state: present
regexp: '^%sudo\s'
@@ -14,7 +14,7 @@
validate: /usr/sbin/visudo -cf %s
- name: Add users | create users' shell and home dir
- user:
+ ansible.builtin.user:
name: "{{ item.logname }}"
shell: /bin/bash
createhome: yes
@@ -22,7 +22,7 @@
with_items: "{{ users }}"
- name: Add authorized keys for user
- authorized_key:
+ ansible.posix.authorized_key:
user: "{{ item.0.logname }}"
key: "{{ item.1 }}"
state: present
@@ -32,7 +32,7 @@
- skip_missing: true
- name: Place user in sudo group
- user:
+ ansible.builtin.user:
name: "{{ item.logname }}"
groups: [sudo]
append: yes
@@ -40,12 +40,12 @@
with_items: "{{ users }}"
- name: Check if /etc/aliases exists
- stat:
+ ansible.builtin.stat:
path: /etc/aliases
register: aliases
- name: Set system email alias
- lineinfile:
+ ansible.builtin.lineinfile:
path: /etc/aliases
state: present
regexp: "^{{ item.logname }}:"