Merge branch 'lint'

Fix linter warnings.

Warnings in imported roles (requirements.txt) cannot be fixed here.

main.yml

@@ -18,7 +18,7 @@
     - name: Ensure unattended-upgrades is installed and up to date
       apt:
         name: unattended-upgrades
-        state: latest
+        state: present
 
     - name: Setup unattended-upgrades
       include_role:

roles/apache/tasks/main.yml

@@ -3,7 +3,7 @@
   apt:
     name:
       - apache2
-    state: latest
+    state: present
 
 - name: Ensure necessary modules are enabled
   apache2_module:

roles/docker_setup/tasks/main.yml

@@ -75,5 +75,5 @@
     name: "{{ item.logname }}"
     groups: docker
     append: yes
-  when: item.docker == true
+  when: item.docker
   with_items: "{{ users }}"

roles/setup-http-site-forward/tasks/main.yml

@@ -2,11 +2,11 @@
 - name: Add or update Apache2 site
   template:
     src: templates/apache-docker-forward-site.j2
-    dest: /etc/apache2/sites-available/{{site_name}}.conf
+    dest: /etc/apache2/sites-available/{{ site_name }}.conf
   notify: restart apache2
 
 - name: Activate Apache2 site
-  command: a2ensite {{ site_name}}
+  command: a2ensite {{ site_name }}
   args:
     creates: /etc/apache2/sites-enabled/{{ site_name }}.conf
   notify: restart apache2

roles/setup-http-site-proxy/tasks/main.yml

@@ -2,11 +2,11 @@
 - name: Add or update Apache2 site
   template:
     src: templates/apache-docker-proxy-site.j2
-    dest: /etc/apache2/sites-available/{{site_name}}.conf
+    dest: /etc/apache2/sites-available/{{ site_name }}.conf
   notify: restart apache2
 
 - name: Activate Apache2 site
-  command: a2ensite {{ site_name}}
+  command: a2ensite {{ site_name }}
   args:
     creates: /etc/apache2/sites-enabled/{{ site_name }}.conf
   notify: restart apache2

roles/users/tasks/main.yml

@@ -37,7 +37,7 @@
     name: "{{ item.logname }}"
     groups: sudo
     append: yes
-  when: item.sudo == true
+  when: item.sudo
   with_items: "{{ users }}"
 
 - name: Check if /etc/aliases exists